fix: make generateDataFromManPages work under Gradle 9#459
Merged
Conversation
Test Results1 048 tests 1 047 ✅ 47s ⏱️ For more details on these failures, see this check. Results for commit fae8e25. |
The `generateDataFromManPages` task failed at execution time with "Could not find method getXsltTransformer() for arguments [] on task ':generateDataFromManPages'". Under Gradle 9's task decoration, a `get`-prefixed method on a task is treated as a property getter, so the direct call `getXsltTransformer()` could no longer be resolved as a method via Groovy dynamic dispatch. Rename the helper to `createXsltTransformer()` (and make it `protected`, matching its sibling helpers) so it is invoked as a plain method. No behavioral change. This unblocks `./gradlew test`, which depends on the task via processResources. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SJrX
force-pushed
the
fix-gradle9-xslt-transformer
branch
from
fae8e25 to
8078557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the private `getXsltTransformer()` helper in `GenerateDataFromManPages` to `protected createXsltTransformer()`.
Why
On `242.x` (Gradle 9.5.1), `./gradlew test` fails because its `generateDataFromManPages` dependency errors at execution time:
```
Could not find method getXsltTransformer() for arguments [] on task
':generateDataFromManPages' of type GenerateDataFromManPages.
```
Under Gradle 9's task decoration, a `get`-prefixed method on a task is treated as a property getter, so the direct call `getXsltTransformer()` can no longer be resolved as a method via Groovy dynamic dispatch. Renaming it away from the `get` prefix (and making it `protected`, matching the sibling helpers `transformDocument`/`buildDocumentProcessingIncludes`) restores the call. No behavioral change.
Verification
With this change, `./gradlew test` runs to completion (previously it could not even reach the test task).
🤖 Generated with Claude Code